Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] test: add design system docs tests #10374

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[tests-only] test: add design system docs tests #10374

merged 1 commit into from
Jan 23, 2024

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jan 19, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

Have more faith in design system changes and allow us to merge deps more quickly

How Has This Been Tested?

  • test environment: macos x64 & CI
  • test case 1: run playwright E2E tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Type:CI Related to our Continouus Integration Solution label Jan 19, 2024
@LukasHirt LukasHirt self-assigned this Jan 19, 2024
@LukasHirt LukasHirt force-pushed the test/design-system-docs-tests branch 4 times, most recently from 889e14e to 1d942d2 Compare January 19, 2024 15:36
@dschmidt
Copy link
Member

Love it!

@LukasHirt LukasHirt force-pushed the test/design-system-docs-tests branch 5 times, most recently from 0f063e0 to e3fd058 Compare January 22, 2024 11:13
@LukasHirt LukasHirt force-pushed the test/design-system-docs-tests branch from e3fd058 to 6e85c64 Compare January 22, 2024 11:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LukasHirt LukasHirt added Category:Technical Technical ehancements Status:Needs-Review Needs review from a maintainer labels Jan 22, 2024
@LukasHirt LukasHirt marked this pull request as ready for review January 22, 2024 11:53
JammingBen
JammingBen approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thank you!

@JammingBen JammingBen merged commit 09584db into master Jan 23, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test/design-system-docs-tests branch January 23, 2024 07:00
ownclouders pushed a commit that referenced this pull request Jan 23, 2024
@JammingBen
Merge pull request #10374 from owncloud/test/design-system-docs-tests
84e42b3 
[tests-only] test: add design system docs tests
@amrita-shrestha amrita-shrestha mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@LukasHirt LukasHirt

Labels
Category:Technical Technical ehancements Status:Needs-Review Needs review from a maintainer Type:CI Related to our Continouus Integration Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasHirt @dschmidt @JammingBen